On Wed, Oct 25, 2023 at 10:10:32AM +0600, Maria Morisot wrote: > > > that you're using correct lengths though, it is possible to get things > > wrong and break programs. > > I was careful to look at the buffer lengths being written and to match them > in strlcpy and snprintf. I peeked at the source for instances of strcpy and > found a lot in xenocara; less in the main source tree. > > I'm willing to change these but I need to know how to submit the altered > files and since it's my first time contributing, I'd love if someone could > double check a bit of my work. >
I think that the explanation of what you are doing and trying to accomplish was a little bit unclear from the responses you got. Upstream means sending your work "up" to the programmers elsewhere who are creating and developing the program. This can allow, if they want to and it doesn't cause problems with other OS's, your changes to be incorporated into the software. This doesn't have anything to do with OpenBSD, except that it will make porting the program into being usable with OpenBSD different. (See ports on the website and the po...@openbsd.org mailing list). So, there is a big difference between changing the original program to work better with OpenBSD or porting it in. Porting in a program means adapting it, possibly with patches that make the changes *only* for OpenBSD. So, Libreoffice isn't an OpenBSD program. Certain patches or changes shouldn't be done locally unless upstream refuses your change. Then, that program will be ported in officially, just marked as broken or dropped as a program for OpenBSD. A really good and simple example is an error in a man page. That sort of change should always be sent upstream first. If they refuse to accept that change, then patch it here. If some flags for our compiler are different, then that is a local adaptation *for OpenBSD*. Do that here and don't bother upstream unless you have questions. Updating programs that are ported in can sometimes be quite difficult when the version changes. That is what Stuart meant about having a nightmare when changing the local copy for us in the way you are doing it. Also, even if everything you have done is 100% perfect, don't be disappointed if your work isn't accepted. Just learn from it and start a new project. OpenBSD has extremely picky and overworked developers. Which is probably why I sleep well at night knowing I have an excellent and secure OS. They do amazingly good work! So even if your first ten tries at different things fail, by the time of your eleventh, you will probably be getting it right by then. Enjoy! -- Chris Bennett
