> On 28 Apr 2016, at 09:00, Marcus MERIGHI <mcmer-open...@tor.at> wrote:
> 
> m...@umaxx.net (Joerg Jung), 2016.04.27 (Wed) 21:53 (CEST):
>> On Wed, Apr 27, 2016 at 09:41:50AM -0400, Bryan Everly wrote:
>>> 
>>> Has anyone had success with either of the new 12" Retina MacBooks?  My
>>> search of marc.info came up empty.
>> 
>> I own a MacBook8,2 and efiboot as well as inteldrm graphics seems to
>> work fine.  However, internal nvme(4) ssd is not detected and the SPI
> 
> Before or after this one?

After of course, with an additional diff to enable it (see below), 
but the controller does not work (yet).

> http://marc.info/?l=openbsd-cvs&m=146069961907725
> Log message:
> enable nvme(4)
> ok dlg@
> 
> Bye, Marcus
> 
> 
>> connected trackpad/mouse also does not work.  The built-in WLAN might
>> never work.  A standard USB3 HUB (connected via adapter), I tested was
>> not really working. So you you can either only attach a USB keyboard or
>> disk or wlan card to the single USB-C port, your choice :) 
>> 
>> Due to this fact I can not provide a copy&paste dmesg.
>> Linux support seems not much better [1].
>> 
>> I have no idea about the 9,x but would like to see a dmesg. 
>> Newer MacbookAir might have the same nvme(4) problem.
>> 
>> Regards,
>> Joerg
>> 
>> [1] https://bugzilla.kernel.org/show_bug.cgi?id=99891
>> 
>> 
>> !DSPAM:57211a01134006737330760!

Index: sys/dev/pci/nvme_pci.c
===================================================================
RCS file: /cvs/src/sys/dev/pci/nvme_pci.c,v
retrieving revision 1.3
diff -u -p -r1.3 nvme_pci.c
--- sys/dev/pci/nvme_pci.c      14 Apr 2016 11:18:32 -0000      1.3
+++ sys/dev/pci/nvme_pci.c      20 Apr 2016 22:10:22 -0000
@@ -70,6 +70,10 @@ nvme_pci_match(struct device *parent, vo
            PCI_INTERFACE(pa->pa_class) == NVME_PCI_INTERFACE)
                return (1);

+       if (PCI_VENDOR(pa->pa_id) == PCI_VENDOR_APPLE &&
+           PCI_PRODUCT(pa->pa_id) == PCI_PRODUCT_APPLE_NVME)
+               return (1);
+
        return (0);
}

Index: sys/dev/pci/pcidevs
===================================================================
RCS file: /cvs/src/sys/dev/pci/pcidevs,v
retrieving revision 1.1792
diff -u -p -r1.1792 pcidevs
--- sys/dev/pci/pcidevs 8 Apr 2016 09:59:47 -0000       1.1792
+++ sys/dev/pci/pcidevs 20 Apr 2016 22:10:22 -0000
@@ -923,6 +923,7 @@ product APPLE INTREPID2_ATA 0x0069  Intre
product APPLE INTREPID2_FW      0x006a  Intrepid 2 FireWire
product APPLE INTREPID2_GMAC    0x006b  Intrepid 2 GMAC
product APPLE BCM5701           0x1645  BCM5701
+product APPLE NVME             0x2001  NVM Express Controller

/* Aralion products */
product ARALION ARS106S         0x0301  ARS106S
Index: sys/dev/pci/pcidevs.h
===================================================================
RCS file: /cvs/src/sys/dev/pci/pcidevs.h,v
retrieving revision 1.1786
diff -u -p -r1.1786 pcidevs.h
--- sys/dev/pci/pcidevs.h       8 Apr 2016 10:00:24 -0000       1.1786
+++ sys/dev/pci/pcidevs.h       20 Apr 2016 22:10:22 -0000
@@ -928,6 +928,7 @@
#define PCI_PRODUCT_APPLE_INTREPID2_FW  0x006a          /* Intrepid 2 FireWire 
*/
#define PCI_PRODUCT_APPLE_INTREPID2_GMAC        0x006b          /* Intrepid 2 
GMAC */
#define PCI_PRODUCT_APPLE_BCM5701       0x1645          /* BCM5701 */
+#define        PCI_PRODUCT_APPLE_NVME  0x2001          /* NVM Express 
Controller */

/* Aralion products */
#define PCI_PRODUCT_ARALION_ARS106S     0x0301          /* ARS106S */
Index: sys/dev/pci/pcidevs_data.h
===================================================================
RCS file: /cvs/src/sys/dev/pci/pcidevs_data.h,v
retrieving revision 1.1781
diff -u -p -r1.1781 pcidevs_data.h
--- sys/dev/pci/pcidevs_data.h  8 Apr 2016 10:00:24 -0000       1.1781
+++ sys/dev/pci/pcidevs_data.h  20 Apr 2016 22:10:23 -0000
@@ -2024,6 +2024,10 @@ static const struct pci_known_product pc
            "BCM5701",
        },
        {
+           PCI_VENDOR_APPLE, PCI_PRODUCT_APPLE_NVME,
+           "NVM Express Controller",
+       },
+       {
            PCI_VENDOR_ARALION, PCI_PRODUCT_ARALION_ARS106S,
            "ARS106S",
        },

Reply via email to