On 25 March 2011 09:44, Glen Anderson <g.s.ander...@gmail.com> wrote:
> Ultimately I think there should be a note explaining what happens in
> the case of non-identical CPUs but without knowing what top does I'm
> happy with either of the following diffs.
>
> I'll have a dig through the source to see if I can find out. I'm not
> holding out much hope as "learn C" has been gathering dust on my todo
> list for a while... A bit of code reading won't do me any harm though.
>

Seems like i_cpustates in display.c is taking a mean. I still think
it's best to leave out any mention of it though. Personally I prefer
the first patch but I'm happy with either.

> $ diff -u top.1 top.1.new
> --- top.1 B  B  B  Thu Mar 24 12:39:45 2011
> +++ top.1.new B  Fri Mar 25 09:28:16 2011
> @@ -75,7 +75,8 @@
> B The options are as follows:
> B .Bl -tag -width Ds
> B .It Fl 1
> -Display CPU statistics on a single line instead of a line per CPU.
> +Display combined CPU statistics on a single line instead of individual CPU
> +statistics on multiple lines.
> B .It Fl b
> B Use
> B .Em batch
> @@ -282,7 +283,8 @@
> B .Sq P
> B interactive command.
> B .It 1
> -Display CPU statistics on a single line instead of a line per CPU.
> +Toggle between combined CPU statistics on a single line and individual CPU
> +statistics on multiple lines.
> B .It C
> B Toggle the display of process command line arguments.
> B .It d Ar count
>
>>>> $ diff -u top.1 top.1.new
>>>> --- top.1 B  B  B  Thu Mar 24 12:39:45 2011
>>>> +++ top.1.new B  Thu Mar 24 17:59:30 2011
>>>> @@ -75,7 +75,8 @@
>>>> B The options are as follows:
>>>> B .Bl -tag -width Ds
>>>> B .It Fl 1
>>>> -Display CPU statistics on a single line instead of a line per CPU.
>>>> +Display CPU statistics for all processors on a single line instead of
>>>> one
>>>> +line per CPU.
>>>> B .It Fl b
>>>> B Use
>>>> B .Em batch
>>>> @@ -282,7 +283,8 @@
>>>> B .Sq P
>>>> B interactive command.
>>>> B .It 1
>>>> -Display CPU statistics on a single line instead of a line per CPU.
>>>> +Toggle CPU statistics between a single line for all processors and one
>>>> line
>>>> +per CPU.
>>>> B .It C
>>>> B Toggle the display of process command line arguments.
>>>> B .It d Ar count

Reply via email to