On Wed, 16 Mar 2011 06:26:20 +1100 Jonathan Gray <j...@goblin.cx> wrote:
> On Tue, Mar 15, 2011 at 06:56:24PM +0100, roberth wrote: > > > > And this one here? > > This should be handled by the default case as the > start of the function, already. Sure, it is, the freebsd driver is checking this twice, my bad. > > > > Index: ixgbe_82599.c > > =================================================================== > > RCS file: /cvs/src/sys/dev/pci/ixgbe_82599.c,v > > retrieving revision 1.2 > > diff -u -p -r1.2 ixgbe_82599.c > > --- ixgbe_82599.c 25 Feb 2010 10:56:07 -0000 1.2 > > +++ ixgbe_82599.c 15 Mar 2011 17:27:55 -0000 > > @@ -416,6 +416,9 @@ enum ixgbe_media_type ixgbe_get_media_ty > > case IXGBE_DEV_ID_82599_CX4: > > media_type = ixgbe_media_type_cx4; > > break; > > + case IXGBE_DEV_ID_82599_T3_LOM: > > + media_type = ixgbe_media_type_copper; > > + break; > > default: > > media_type = ixgbe_media_type_unknown; > > break;
