https://bugzilla.redhat.com/show_bug.cgi?id=1306047
Erik van Pienbroek <erik-fed...@vanpienbroek.nl> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
--- Comment #7 from Erik van Pienbroek <erik-fed...@vanpienbroek.nl> ---
If I understand the patch correctly there are 3 different changes here:
- The glib-prefer-constructors-over-DllMain patch is improved so it also covers
a similar issue in the gobject library
- A BR: mingw{32,64}-pcre is added so that the external PCRE library is used
instead of the bundled one
- A BR: mingw{32,64}-winpthreads is added
It appears that the DllMain in gobject was added just recently:
https://git.gnome.org/browse/glib/commit/gobject/gtype.c?id=7a29771a743a8b5337af5f3fcd1fbfdfdc5d1b81
and appears to have been done to fix a compatibility issue with
MSVC2015/Windows 10 SDK: https://bugzilla.gnome.org/show_bug.cgi?id=752837
For mingw I think the updated patch is correct although it may not work
correctly anymore for MSVC..
The change about pcre looks good enough to more, external libraries should be
used where possible
The last one shouldn't be necessary. winpthreads should already automatically
get pulled in by mingw{32,64}-gcc
In your updated patch the posix threading configure argument seem to have
gotten lost. Was this intentional?
--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
mingw mailing list
mingw@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/mingw@lists.fedoraproject.org
