https://bugzilla.redhat.com/show_bug.cgi?id=1066559



--- Comment #4 from David King <amigad...@amigadave.com> ---
Thanks for the comments! I fixed 1, 2, 3, 4. Not sure about 5, as I do not
really know the convention (looking at the example in
https://fedoraproject.org/wiki/Packaging:MinGW#Example_Specfile). I added your
patch (slightly modified to use autoreconf rather than a bootstrap script),
added the -no-undefined change to the existing id3lib-3.8.3-mingw.patch and
updated the .spec and SRPM in place:

Spec URL: http://amigadave.fedorapeople.org/mingw-id3lib.spec
SRPM URL: http://amigadave.fedorapeople.org/mingw-id3lib-3.8.3-31.fc20.src.rpm

Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6564355

I suppose it makes sense to get the autoreconf patch into the native package
too? It saves a few hundred kB in the SRPM size. :-)

I do not get the opportunity to use Windows much, but I will try with some
non-ASCII characters with EasyTAG the next time I do some testing.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=LHu91UtEm8&a=cc_unsubscribe
_______________________________________________
mingw mailing list
mingw@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/mingw

Reply via email to