On Fri, 12 Sep 2025, Kirill Makurin wrote:

Thank you for review, I'll take care of this in the coming days.

About patch 3/8; It fixes compilation with C++ or MSVC. These tests are no-op when compiled as C with gcc/clang. For these tests and some other, I was thinking we could make them compile with C++ afterwards. I wanted to take care of this after we get tests working with the build system.

Right, that's probably ok as well. But to make the context of the patch clearer, I'd suggest explaining this in the commit message - that these tests really aren't compiled properly in the current setup, and that might be fixed in a future patch.

I not familiar with GitHub CI, but I can look into it.

Thanks, that'd be appreciated. As long as you have a github account and activate actions on your fork, it's quite easy to just try, push to your fork, inspect the results and iterate on it.

For working on the CI integration of testcases, you may want to pick https://github.com/mstorsjo/mingw-w64/commit/ci-only-testcases into your test branch as well; this skips running the other long jobs, and only run the testcases jobs, and using an external gcc build snapshot rather than rebuilding it each time - with that, you should be able to iterate in ~5 minutes per attempt.

// Martin



_______________________________________________
Mingw-w64-public mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Reply via email to