On 21.03.2025 22:43, Martin Storsjö wrote:
On Fri, 21 Mar 2025, Jacek Caban wrote:
---
mingw-w64-crt/Makefile.am | 2 --
mingw-w64-crt/def-include/crt-aliases.def.in | 2 ++
.../lib-common/api-ms-win-crt-math-l1-1-0.def.in | 1 +
mingw-w64-crt/math/arm/_chgsignl.S | 16 ----------------
mingw-w64-crt/math/arm64/_chgsignl.S | 16 ----------------
5 files changed, 3 insertions(+), 34 deletions(-)
delete mode 100644 mingw-w64-crt/math/arm/_chgsignl.S
delete mode 100644 mingw-w64-crt/math/arm64/_chgsignl.S
diff --git a/mingw-w64-crt/Makefile.am b/mingw-w64-crt/Makefile.am
index f2f1e6f81..fc53b8256 100644
--- a/mingw-w64-crt/Makefile.am
+++ b/mingw-w64-crt/Makefile.am
@@ -1050,7 +1050,6 @@ src_libmingwex64=$(src_libmingwex_x86)
# these only go into the ARM32 version:
src_libmingwexarm32=\
- math/arm/_chgsignl.S \
math/arm/s_rint.c math/arm/s_rintf.c
if ENABLE_SOFTMATH
@@ -1078,7 +1077,6 @@ endif
# these only go into the ARM64 version:
src_libmingwexarm64=\
- math/arm64/_chgsignl.S \
math/arm64/rint.c math/arm64/rintf.c \
math/arm64/sincos.S math/arm64/sincosf.S \
math/arm-common/ldexpl.c
diff --git a/mingw-w64-crt/def-include/crt-aliases.def.in
b/mingw-w64-crt/def-include/crt-aliases.def.in
index 5f1f8bfad..d682c8b42 100644
--- a/mingw-w64-crt/def-include/crt-aliases.def.in
+++ b/mingw-w64-crt/def-include/crt-aliases.def.in
@@ -593,3 +593,5 @@ ADD_UNDERSCORE(vsnprintf_s)
#ifndef CRTAPP
ADD_UNDERSCORE(wpopen)
#endif
+
+F_LD64(_chgsignl == _chgsign)
This file does seem to have some sort of sections for various
categories, but I'm not sure which one of them is the best and most
relevant fit for this symbol.
Other than wondering about the placement within the file, this patch
looks quite ok to me.
I sent a v2 moving it to the section where other long double aliases are
defined.
Thanks,
Jacek
_______________________________________________
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
