On Mon, 17 Mar 2025, Jacek Caban wrote:

---
mingw-w64-crt/def-include/crt-aliases.def.in  |  30 ++-
.../api-ms-win-crt-convert-l1-1-0.def.in      |   8 +-
.../api-ms-win-crt-math-l1-1-0.def.in         | 148 ++++++-------
.../lib-common/ucrtbase-common.def.in         | 194 +++++++++---------
4 files changed, 189 insertions(+), 191 deletions(-)

diff --git a/mingw-w64-crt/def-include/crt-aliases.def.in 
b/mingw-w64-crt/def-include/crt-aliases.def.in
index 06526dde5..e6953714b 100644
--- a/mingw-w64-crt/def-include/crt-aliases.def.in
+++ b/mingw-w64-crt/def-include/crt-aliases.def.in
@@ -251,27 +251,25 @@ wcstok == wcstok_s
ADD_UNDERSCORE(nextafter)
#endif

-#if defined(__arm__) || defined(__aarch64__)
; This is list of symbol aliases for C99 ARM long double functions
; They are defined as aliases to regular double symbols as on ARM, long double 
is equal to regular double
-acosl == acos
-asinl == asin
-atan2l == atan2
-atanl == atan
-ceill == ceil
-cosl == cos
-expl == exp
-floorl == floor
-fmodl == fmod
-log10l == log10
-logl == log
+F_LD64(acosl == acos)
+F_LD64(asinl == asin)
+F_LD64(atan2l == atan2)
+F_LD64(atanl == atan)
+F_LD64(ceill == ceil)
+F_LD64(cosl == cos)
+F_LD64(expl == exp)
+F_LD64(floorl == floor)
+F_LD64(fmodl == fmod)
+F_LD64(log10l == log10)
+F_LD64(logl == log)
; FIXME: Why is powl alias defined only for UCRT?
#ifdef UCRTBASE
-powl == pow
-#endif
-sinl == sin
-tanl == tan
+F_LD64(powl == pow)
#endif
+F_LD64(sinl == sin)
+F_LD64(tanl == tan)

; This is list of symbol aliases for C11 functions
#ifdef UCRTBASE
diff --git a/mingw-w64-crt/lib-common/api-ms-win-crt-convert-l1-1-0.def.in 
b/mingw-w64-crt/lib-common/api-ms-win-crt-convert-l1-1-0.def.in
index 651b81c2a..f48deaae4 100644
--- a/mingw-w64-crt/lib-common/api-ms-win-crt-convert-l1-1-0.def.in
+++ b/mingw-w64-crt/lib-common/api-ms-win-crt-convert-l1-1-0.def.in
@@ -47,7 +47,7 @@ _strtoi64
_strtoi64_l
_strtoimax_l
_strtol_l
-F_ARM_ANY(_strtold_l) ; Can't use long double functions from the CRT on x86
+F_LD64(_strtold_l)

The patch in itself looks good to me. I guess one can debate whether these comments should be kept or not (to indicate places where we've applied manual modifications, as opposed to just arch specific differences between architectures in what gendef outputs) though.

// Martin



_______________________________________________
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Reply via email to