On Monday 17 March 2025 23:44:25 Jacek Caban wrote:
> On 17.03.2025 21:35, Pali Rohár wrote:
> > Enable underscored fpreset alias for ARM targets in crt-aliases.def.in
> > include file, which is automatically included into all msvcr*.def.in and
> > ucrt*.def.in files.
> >
> > Underscored alias is still present in api-ms-win-crt-runtime-l1-1-0.def.in
> > file as api-ms-win-crt*.def.in files do not use crt-aliases.def.in yet.
> >
> > This change fixes more issues with commit 87ec8e6c5a62 ("crt: Use .def
> > files for fpreset and _fpreset on ARM targets.") which:
> > - enabled underscored alias also for i386 and x64 msvcr120_app.dll builds
> > - forgot to add underscored alias for arm32 msvcr110.dll builds
> > - added duplicated code into individual msvcr*.def.in files, which was
> > already de-duplicated
> > - removed comment about DATA keywords (manually added needs to be revisited)
>
>
> LGTM, thanks. The comment was intentionally removed, I think using the macro
> is self-explanatory, but I don’t mind keeping it if it serves a purpose.
>
Those commends are good for checking or marking items which needs to be
revisited. It is useful to know there is an extra DATA compared with
gendef output.
> > ---
> > mingw-w64-crt/def-include/crt-aliases.def.in | 4 ++++
> > mingw-w64-crt/lib-common/api-ms-win-crt-runtime-l1-1-0.def.in | 3 +--
> > mingw-w64-crt/lib-common/msvcr120_app.def.in | 1 -
> > mingw-w64-crt/lib-common/msvcrt.def.in | 1 -
> > mingw-w64-crt/lib-common/ucrtbase-common.def.in | 3 +--
> > mingw-w64-crt/libarm32/msvcr110d.def.in | 1 -
> > mingw-w64-crt/libarm32/msvcr120.def.in | 1 -
> > mingw-w64-crt/libarm32/msvcr120d.def.in | 1 -
> > 8 files changed, 6 insertions(+), 9 deletions(-)
> > ---
> >
> > Now when I'm looking at this change, I think that there is another
> > problem with _fpreset in some *cr* builds. It is needed to add
> > "DATA" keyword into all i386 and x64 definitions of _fpreset.
>
>
> Probably yes.
>
>
> > And seems that the mingw-w64-crt/crt/CRT_fp8.c file should be
> > completely removed as it looks like that its symbols are in direct
> > conflict with fp10.c symbols and symbols in individual def files.
>
>
> It's still used in !W32API case.
>
>
> Thanks,
>
> Jacek
>
Interesting, it is used or it is really working?
_______________________________________________
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
