在 2025-01-30 19:20, Jonathan Yong 写道:
The 2 patches look OK to me, I'll wait for feed back from the others.
The second patch introduces a private implementation of `getntptimeofday()` that does not write anything into `*tz`. Although all calls to this function in that file pass null pointers for its second parameter, I would like to say it's not very ideal.
Also, it looks like `getntptimeofday()` isn't a standard function...? Does it make sense to change `getntptimeofday(&tp, NULL)` to `clock_gettime(CLOCK_REALTIME, &tp)` which is then defined in winpthreads so must always exist?
-- Best regards, LIU Hao
OpenPGP_signature.asc
Description: OpenPGP digital signature
_______________________________________________ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
