On Thursday 24 October 2024 14:39:58 Martin Storsjö wrote: > On Thu, 17 Oct 2024, Pali Rohár wrote: > > > On Friday 11 October 2024 12:00:41 Martin Storsjö wrote: > > > On Sat, 28 Sep 2024, Pali Rohár wrote: > > > > > > > diff --git a/mingw-w64-crt/lib-common/msvcr120_app.def.in > > > > b/mingw-w64-crt/lib-common/msvcr120_app.def.in > > > > index 4508a43f3370..eadcda310ad8 100644 > > > > --- a/mingw-w64-crt/lib-common/msvcr120_app.def.in > > > > +++ b/mingw-w64-crt/lib-common/msvcr120_app.def.in > > > > @@ -2310,7 +2310,7 @@ wcsstr > > > > wcstod > > > > wcstof > > > > wcstoimax > > > > -wcstok > > > > +_wcstok == wcstok ; rename wcstok to _wcstok for compatibility with > > > > UCRT, real C95+ compatible wcstok provided by wcstok_s alias > > > > > > This comment is a bit hard to understand, and as this text is copypasted a > > > number of times, it would be good to get it understandable enough from the > > > start. > > > > > > What about this description? > > > > > > Provide the nonstandard function with the name "wcstok" in the DLL, under > > > the name "_wcstok" to match the corresponding function in UCRT. The real > > > C95+ compatible wcstok is provided by (mingw-w64 or wcstok_s alias) > > > > Of course, feel free to update any comment if it is not clear. > > Just maybe the comment could be shorter as it is copied in every one file. > > Yeah... Let's try a condensed form: > > ; provide nonstandard function "wcstok" in the DLL, under the name "_wcstok" > to match UCRT, the C95+ compatible "wcstok" is provided by (mingw-w64 or > wcstok-s alias) > > That's only slightly longer than your original version, while I think it > still makes the relevant references a bit more clear. > > // Martin
Sounds good, thanks! _______________________________________________ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
