On Wed, 23 Oct 2024, LIU Hao wrote:

在 2024-10-23 04:58, Martin Storsjö 写道:
Did you verify this aspect with all these libraries (testing setting rounding and calling our math functions?), or is this just repeating the same statement that was tested with UCRT?

Technically I think the patch is fine, but I'm a little weary about adding statements saying something about how things behave with a library unless we actually did test that.

Strictly speaking, it's only true for x86-64. Microsoft declare x87 FPU deprecated on x86-64 and there's no type for 10-byte extended-precision type in their ABI, so MSVCR120* DLL only check and update MXCSR.

For x86-32, MXCSR is passively updated from the x87 FPU control word.

Thanks, this sounds reasonable. So for old x86 32 bit, this argument isn't relevant, and it could be concievable that these functions should work together with our implementations in libmingwex?

// Martin

_______________________________________________
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Reply via email to