On 18.10.2024 18:09, David Grayson wrote:
Indeed there are still numerous bugs in intsafe.h reported by my test
suite, even after applying the patch.
For example, SSIZETToLong is needlessly redefined, resulting in it having
the incorrect type for its first argument (LONGLONG instead of SSIZE_T).
My tests are here: https://github.com/DavidEGrayson/intsafe
I don't mind if you merge Jacek's patch, but I will also try to get my
tests passing soon and submit another patch.
--David
On Fri, Oct 18, 2024 at 7:38 AM Martin Storsjö <mar...@martin.st> wrote:
On Fri, 18 Oct 2024, Jacek Caban wrote:
We have inline versions that do the right thing in all cases.
Fixes: 0cf06d5cb6968ad71d36a193eeb04f3266bb3aaa
Signed-off-by: Jacek Caban <ja...@codeweavers.com>
---
mingw-w64-headers/include/intsafe.h | 26 +-------------------------
1 file changed, 1 insertion(+), 25 deletions(-)
LGTM, these two patches seem very straightforward and ok to me - thanks!
Regarding the rest of the defines added in
0cf06d5cb6968ad71d36a193eeb04f3266bb3aaa, how many are really needed, and
how many just mask an existing inline version?
Yeah, most macros duplicated seem harmless as they use *IntPtr variants,
but it's more important for some (and duplication is not great too).
Thanks for reviews, I pushed those patches.
Jacek
_______________________________________________
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
