On Mon, 25 Sep 2023, Mark Harmstone wrote:
Some of these were added by the previous patch, and some are new.
Signed-off-by: Mark Harmstone <[email protected]>
---
diff --git a/mingw-w64-crt/Makefile.am b/mingw-w64-crt/Makefile.am
index 7f137b4f0..1b2caeab5 100644
--- a/mingw-w64-crt/Makefile.am
+++ b/mingw-w64-crt/Makefile.am
@@ -2029,6 +2029,7 @@ endif
%/libapi-ms-win-core-com-l1-1-2.a \
%/libapi-ms-win-core-com-l1-1-3.a \
%/libapi-ms-win-core-com-midlproxystub-l1-1-0.a \
+ %/libapi-ms-win-core-com-l1-1-0.a \
%/libapi-ms-win-core-comm-l1-1-0.a \
This is a stray change (it adds a duplicate l1-1-0.a dependency on
mincore, while this patch touches windowsapp).
Other than, I think this patchset looks good.
Steve Lhomme sent a similar patchset on June 26th. I reviewed it (quite
belatedly, sorry about that) on July 20th, where I requested it to be
split into smaller pieces; that patchset both added new symbols and new
def files, and removed other def files that weren't reachable with the
mincore/windowsapp headers that he had compared with.
I compared the end result of this patchset and Steve's, and this one
should be a superset (after adding the extra two patches I just sent);
there are still def files that might not be reachable with current MS
import libraries, but if important, those can be pruned in a separate
step.
So if there aren't any objections to it, I would go ahead and push these
two patches sometime soon.
// Martin
_______________________________________________
Mingw-w64-public mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
