On 7/23/23 11:58, LIU Hao wrote:
在 2023-07-23 13:57, Biswapriyo Nath 写道:
From 2a64bfe452a92a5197b2e102f5d46c28d14a7631 Mon Sep 17 00:00:00 2001
From: Biswapriyo Nath<[email protected]>
Date: Sun, 23 Jul 2023 11:17:05 +0530
Subject: [PATCH 3/3] headers: Define D2D1FORCEINLINE where needed
Signed-off-by: Biswapriyo Nath<[email protected]>
---
mingw-w64-headers/include/d2d1_1helper.h | 4 ++++
mingw-w64-headers/include/d2d1helper.h | 4 ++++
2 files changed, 8 insertions(+)
Thanks for the patches. Pushed to master now.
The commit is missing some files generated from IDLs, so current tree
doesn't build.
Even more importantly, D2D headers have a lot of C++ features, like
inline function helpers that overload virtual functions, that are not
expressed in Wine IDLs. There is a reason why MS doesn't use IDLs for
D2D and it's the same reason we never imported those IDLs. That makes
IDLs very incompatible with Windows SDK headers. Those patches broke
Firefox build in multiple ways. It should be possible to share more of
D2D between Wine and mingw-w64, but not without more work, careful
consideration and proper review. I feel like all of that was missing in
this case.
Anyway, given that the whole series is just plain wrong, I suggest to
revert it all.
Jacek
_______________________________________________
Mingw-w64-public mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
