On Mon, 26 Jun 2023, Steve Lhomme wrote:
The previous SDKs had some bogus removals which were added back in 19H1.
That is, previous WinSDK versions were lacking some symbols in
windowsapp.lib, that now are available again in newer versions? Are you
sure you compare the exact same architectures each time, since the
contents for some lower level functions actually do differ between
architectures?
The removed files had their API's moved to "lower" versions of the DLL
they are picked from there.
The update libraries match exactly the exported API's from windowsapp
19H1 into each DLL. There should be no duplicate between the DLLs.
Some 20H1 API's have been temporarily removed.
I don't understand what this comment means here.
We keep some define files that are needed by mincore.
I'd prefer "def file" here, as I haven't seen anything else refer to them
as define files.
So what you mean, is that the def files that no longer are
needed/referenced from windowsapp in this commit are removed, except for
the ones that are referenced in mincore? What if this commit removes
symbols from the def file referenced in mincore (but the new def file
isn't added to mincore)?
249 files changed, 662 insertions(+), 3273 deletions(-)
This patch is really hard to review - and previous review history shows
that it's easy to make mistakes, even if the input is mostly automated
here, so we really want to be able to check the effect of this change from
all points of view.
I'm wondering what would be the best way to split it up so that we can
somehow have a chance at reviewing it (while not making insanely much
extra work for you).
Would it be possible to split it like this:
- Add new def files and new symbols to existing def files. At this point,
our windowsapp should be a superset of the WinSDK windowsapp - i.e. we
have symbols provided by more than one DLL, and providing some symbols
which WinSDK probably doesn't provide.
- Remove def files from windowsapp.mri, if they refer to a DLL that is not
at all referenced in current WinSDK windowsapp. Remove the def file from
git if mincore.mri doesn't reference it
- Remove symbols from def files that now are in a different DLL in
windowsapp, but where that DLL still is referenced for other symbols. Here
we should be able to check if this affects mincore in some way.
Alternatively, if mincore isn't really relevant for anyone any longer, we
could consider dropping it, if it eases our maintainance?
// Martin
_______________________________________________
Mingw-w64-public mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
