On Wed, 8 Mar 2023, Jameson Nash wrote:
Alright, let's try that again!
On Wed, Mar 8, 2023 at 11:54 AM Alvin Wong <al...@alvinhc.com> wrote:
Hi, it seems the mailing list software stripped your attached patch.
Please try resending it with a .txt file extension. (I suspect that
Gmail doesn't send the .patch files with the MIME type `text/plain`.)
On 7/1/2023 11:10, Jameson Nash wrote:
I noticed that gdtoa upstream appeared to have some changes that were not
reflected here, so I tried to copy them into mingw-w64 here. I had to
partly guess at what the diff was between the old and current versions
because upstream does not seem to provide version control, so this is a
bit
hard to illustrate. For future reference, this is the content from today:
https://github.com/vtjnash/gdtoa/commit/a37a5e1354210f135003cc734cb097eee48e58b5
,
which is also included as a tgz in the commit here for future reference.
I
did not import any of the new features (new files) since those are not
specified as part of C9x or POSIX, so they did not seem necessary.
Thanks for the patch.
We probably don't want to commit the tgz with the unaltered sources to our
git though - but for sorting out future incremental changes on top,
having the commit reference (as you mentioned in the cover letter) is
great - I think it'd be good to include that in the commit message
too.
Other than that, the patch looked good to me, so I gave it a spin in a
couple of testsuites.
Unfortunately, the libcxx testsuite found one failing test caused by this
patch. The root cause seems to be that strtod("nan", NULL) returns zero
instead of a valid NAN. Can you look into why that is?
// Martin
_______________________________________________
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
