You're right, but wouldn't that result in a non-optimized Skylake, sacrificing AVX2 instructions for everyone?.
I believe that if you run a build without removing qemu-usermode, then test that on hardware and check for optimizations you wouldn't get any of the avx2 optimizations, the system will work, but are we okay with defaulting to a non-optimized system?, I'm not trying to undo this change (it would work for me), I'm merely asking if that's what should be provided by meta-intel Alejandro On Thu, 25 Feb 2021 at 01:59, Saini, Naveen Kumar < [email protected]> wrote: > Hi Alejandro, > > > > AVX instructions are excluded if qemu-usermode is enable. > > > https://git.yoctoproject.org/cgit/cgit.cgi/meta-intel/tree/conf/machine/include/tune-skylake.inc#n31 > > and > > > https://git.yoctoproject.org/cgit/cgit.cgi/meta-intel/tree/conf/machine/include/tune-skylake.inc#n33 > > > > I am able to build gobject-introspection. > > > > Regards, > > Naveen > > > > *From:* Alejandro Hernandez <[email protected]> > *Sent:* Thursday, February 25, 2021 9:50 AM > *To:* Saini, Naveen Kumar <[email protected]> > *Cc:* [email protected] > *Subject:* Re: [meta-intel] [PATCH] tune-skylake.inc: allow to enable > qemu-usermode > > > > Hey Naveen, > > > > Unless QEMU got support for AVX2, I'm pretty sure this will start breaking > things that depend on qemu-usermode, were you able to test this with > something that uses gobject-introspection? > > > > Alejandro > > > > On Thu, 25 Feb 2021 at 01:24, Naveen Saini <[email protected]> > wrote: > > Currenty qemu-usermode is being removed from MACHINE_FEATURES,which > does not allow user to build in qemu-usermode even though AVX instructions > are not enabled. > > Check for qemu-usermode and AVX instructions set is already in place. > > [YOCTO #14248] > > Signed-off-by: Naveen Saini <[email protected]> > --- > conf/machine/include/tune-skylake.inc | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/conf/machine/include/tune-skylake.inc > b/conf/machine/include/tune-skylake.inc > index 4882600b..7f03c714 100644 > --- a/conf/machine/include/tune-skylake.inc > +++ b/conf/machine/include/tune-skylake.inc > @@ -24,9 +24,6 @@ PACKAGE_EXTRA_ARCHS_tune-skylake-64 = > "${PACKAGE_EXTRA_ARCHS_tune-core2-64} skyl > QEMU_EXTRAOPTIONS_skylake-64 = " -cpu Skylake-Client" > > > -# Disable QEMU usermode by default (get avx2) > -MACHINE_FEATURES_remove = "qemu-usermode" > - > # If qemu-usermode is enabled, we have to disable avx2 ISA extensions, > but we can keep mtune as skylake vs generic > SKYLAKE_TUNE .= "${@bb.utils.contains('MACHINE_FEATURES', > 'qemu-usermode', ' -mtune=skylake ${QEMU_UNAVAILABLE_ISA}', '-mtune=generic > -mavx2', d)} > <$%[email protected]('MACHINE_FEATURES',%20'qemu-usermode',%20'%20-mtune=skylake%20$%7bQEMU_UNAVAILABLE_ISA%7d',%20'-mtune=generic%20-mavx2',%20d)%7d> > " > > -- > 2.17.1 > > > > >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#6947): https://lists.yoctoproject.org/g/meta-intel/message/6947 Mute This Topic: https://lists.yoctoproject.org/mt/80892807/21656 Group Owner: [email protected] Unsubscribe: https://lists.yoctoproject.org/g/meta-intel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
