On 26/02/2024 16:51, Devarsh Thakkar wrote:
Hi Andrew, Sinthu,
On 13/02/24 21:35, Andrew Davis wrote:
On 2/13/24 3:27 AM, Sinthu Raja M wrote:
On Tue, Feb 13, 2024 at 2:17 PM Tomi Valkeinen
<[email protected]> wrote:
On 13/02/2024 10:28, Devarsh Thakkar wrote:
+Tomi.
Hi Sinthu, Andrew,
On 13/02/24 12:11, Sinthu Raja M wrote:
On Mon, Feb 12, 2024 at 10:36 PM Andrew Davis via
https://linkprotect.cudasvc.com/url?a=https%3a%2f%2flists.yoctoproject.org&c=E,1,2DS7l4Ll0Z71XJHz-8l2SWUjg27KV1rvg3XF0AMYsnwQk1_ugC9LSBcJkDKPbky1ukBO3cDGKWYMyz4aGetIoLWygeMbGXIVsFLmFXec-9wrwA,,&typo=1
<[email protected]> wrote:
On 2/12/24 10:31 AM, Sinthu Raja M via
https://linkprotect.cudasvc.com/url?a=https%3a%2f%2flists.yoctoproject.org&c=E,1,kscN3qPdyfL8tn7Fw-OJJ9CSmKtK9jbcAAMJp2zK3KmVWYUG53IuOFVHam_hakwWdc6Wz-dhlHPCRsgWyFh-wNcu5rYmRVFvsvOAzklEyTdmmp7vwy5aHK4QNX0,&typo=1
wrote:
From: Sinthu Raja <[email protected]>
AM57x platform supports OMAP DRM. By default the pykms library
disabled the OmapCard support. Enable the same by defining the
HAS_LIBDRM_OMAP as a compiler flags
What project uses this feature? I didn't think there were any
remaining users of the libdrm OMAP specific framebuffers.
I am not sure about the users of the libdrm, As mentioned AM57x SDK
uses OMAP DRM and all the DSS test cases from LTP that use the PYKMS
library are failing due to the OmapCard property being unavailable.
Devarsh/Udit,
Please help in understanding the project that uses this feature.
The only reason to use OmapCard and OmapFramebuffer is to use the TILER.
If none of the users need TILER, there's no reason to enable the OMAP
support. But no harm either.
That said, kms++ automatically builds in the omap support if the
https://linkprotect.cudasvc.com/url?a=https%3a%2f%2flibdrm_omap.so&c=E,1,F-fI2ZgbaQwMkyR6160HbqwP2KIOJTL1ocsF1DbtMr1q-ikrrR7qt-6RBMAiodzw_sRQMFEoBWSLDqy1FRCACt9HWnTxKqq0f8ylrjtF-_o-kw,,&typo=1
is found, and it also enables the OMAP support for the
python bindings. So it should "just work". However, the kms++ meson
files had a bug and the OMAP support for py bindings was not enabled
correctly. This has been fixed quite a while ago in upstream kms++.
Looking at the patch, if I read it right, it doesn't look correct as it
unconditionally enables HAS_LIBDRM_OMAP. HAS_LIBDRM_OMAP should only be
set if the libdrm_omap is available.
Tomi
Thanks, Tomi.
Denys/Andrew,
As Tomi mentioned the fix is available in the below commit of [1].
2236a8ccacdfed5ff5f6873ed6618eccf570193d. Please suggest in that case
if is it fine to change the SRCREV of this recipe or just backport the
patch.
If there is a fix upstream then bump the SRCREV to the latest.
[1]: https://github.com/tomba/kmsxx
Sinthu Raja.
Andrew
I am not sure I got the question but to elaborate libdrm is a basic component
required and enabled for all TI platforms involving display as it provides
test utilities and drm/kms helper libs.
I was asking specifically about the OmapCard feature, not libdrm itself.
Do any of our demos or tests still use that, if so we should fix that,
OmapCard/OmapFramebuffer should be deprecated out.
I discussed with Tomi regarding this and he said that omap card feature is
only enabled if libdrm_omap is present which can be used by applications to do
rotation and stuff.
If libdrm_omap is not present then pykms (kms++ library) automatically
disables omapcard.
So we don't think it needs to be deprecated explicitly at pykms level when
driver and middleware are already supporting it and pykms automatically
disables omapcard when libdrm_omap is not present.
Tomi, please add if I missed any of the points we discussed.
Depends what "deprecated" means. If none of the tests need the OMAP
specific features, I do think it's better if the tests just use the
normal Card and DumbFramebuffer classes from kms++, as then they're (at
least mostly) generic to all platforms.
Tomi
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#15210):
https://lists.yoctoproject.org/g/meta-arago/message/15210
Mute This Topic: https://lists.yoctoproject.org/mt/104314617/21656
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/meta-arago/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
