On Thu, Jun 08, 2023 at 03:47:51PM -0500, Randolph Sapp via 
lists.yoctoproject.org wrote:
> From: Randolph Sapp <[email protected]>
> 
> These were incorrect and OE-Core has been carrying the equivalent patch
> since 42344347be2.

Well, I agree with the code change - these are now redundant.

But the message is not right - these were perfectly correct at the time 
(later those were changed from /bin/nologin to /sbin/nologin upstream) and 
the commit referred dealt with override syntax change, the actual addition 
of useradd lines per PACKAGECONFIG happened a bit earlier...

Also, since you are removing networkd and resolved specific changes, can you 
move appending these PACKAGECONFIGs to arago.conf, like you do in patch #2?


> Signed-off-by: Randolph Sapp <[email protected]>
> ---
>  meta-arago-distro/recipes-core/systemd/systemd_%.bbappend | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/meta-arago-distro/recipes-core/systemd/systemd_%.bbappend 
> b/meta-arago-distro/recipes-core/systemd/systemd_%.bbappend
> index 9e49ac69..a38ca124 100644
> --- a/meta-arago-distro/recipes-core/systemd/systemd_%.bbappend
> +++ b/meta-arago-distro/recipes-core/systemd/systemd_%.bbappend
> @@ -3,8 +3,6 @@ PR:append = ".arago6"
>  FILESEXTRAPATHS:prepend := "${THISDIR}/${PN}:"
>  
>  PACKAGECONFIG:append = " networkd resolved"
> -USERADD_PARAM:${PN} += "--system -d / -M --shell /bin/nologin 
> systemd-network;"
> -USERADD_PARAM:${PN} += "--system -d / -M --shell /bin/nologin 
> systemd-resolve;"
>  
>  SRC_URI:append = " \
>      file://local.rules \
> -- 
> 2.41.0


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#14561): 
https://lists.yoctoproject.org/g/meta-arago/message/14561
Mute This Topic: https://lists.yoctoproject.org/mt/99415872/21656
Group Owner: [email protected]
Unsubscribe: 
https://lists.yoctoproject.org/g/meta-arago/leave/10763299/21656/89520264/xyzzy 
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-


Reply via email to