On 6/6/23 1:52 PM, Brnich, Brandon wrote:
Hello Andrew,
-----Original Message-----
From: Davis, Andrew <[email protected]>
Sent: Monday, May 22, 2023 2:22 PM
To: Brnich, Brandon <[email protected]>; Etheridge, Darren
<[email protected]>; [email protected]
Cc: Thakkar, Devarsh <[email protected]>
Subject: Re: [meta-arago][master/kirkstone][PATCH] receipes-multimedia:
gstreamer: Add kmssink support
On 5/22/23 12:58 PM, Brandon Brnich via lists.yoctoproject.org wrote:
Remove the old bbapend files that dealt with old gstreamer version.
These files applied patches to hack gstreamer to work with our
devices. We are no longer carrying these patches into kirkstone. Our
devices should work with the kirkstone packaged gstreamer.
The important part of these patches was GST DRM Allocator support, quick
check I see it used by:
gstreamer1.0-plugins-vpe
gstreamer1.0-plugins-ducati
Would be nice to keep multimedia acceleration working on all the non-K3
platforms..
I'm guessing these could be converted without too much effort to one of
these[0] and if so do you have any timelines for that?
At this point in time, there is no timeline for supporting these old platforms.
Porting these patches are not trivial as gstreamer structure has changed quite
significantly since 1.16. For K3 platforms, the GST DRM Allocator is not
required.
Not sure what best course of action is. Is it best to not accept these patches
and leave
the bb append files in the tree where they aren't necessarily hurting anything
because
the revision number is wrong so none of these patches are being applied?
Should this series be accepted?
With this, we are optimistic in that someone will eventually update the patches
to enable DRM allocation
on these out of date platforms.
Optimism isn't going to fix gstreamer. No one is going to "eventually" fix this
and we
should just be honest with ourselves about that. Just remove them. Make a new
patch for that.
Also in a different patch, if you need kmssink, be sure to explain "why" you
need it,
do not just describe what your patch does in the commit message.
Andrew
If dropping ducati and vpe support is chosen, then [0] should be accepted
because kmssink enablement is required on K3 platforms and since nothing else
needs to be
changed on gst-plugins-bad, arago.conf seems to be the place to do it. Denys
also made that remark
here [1]. I can send in another series to just delete this bbapend as a whole
since enablement is not
needed here.
Gst-plugins-good will need to stay because there is a patch that will need to
be carried here.
Regardless, this series will need a v2. Just trying to figure out the best way
to approach this problem.
[0] https://lists.yoctoproject.org/g/meta-arago/topic/98990987#14426
[1] https://lists.yoctoproject.org/g/meta-arago/topic/99070450#14434
[0]
https://gstreamer.freedesktop.org/documentation/allocators/index.html?gi
-language=c
Andrew
Best,
Brandon
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#14539):
https://lists.yoctoproject.org/g/meta-arago/message/14539
Mute This Topic: https://lists.yoctoproject.org/mt/99070450/21656
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/meta-arago/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-