Hi Devarsh, Thanks for the review,
On May 23, 2023 at 17:18:39 +0530, Devarsh Thakkar wrote: > Hi Jai, > > Thanks for the patch. > > On 23/05/23 15:14, Jai Luthra wrote: > > An older recipe (v1.22.0) is present in the meta-openembedded/meta-oe > > layer for kirkstone. > > > > TI's 6.1 based kernel has backported multistream routing APIs [1] from > > upstream kernel, which requires a few patches to v4l-utils [2] that only > > apply cleanly on top of v1.23.0. > > > > Thus we override the recipe in this layer to the latest (v1.23.0) found > > from meta-oe master. > > > > Link: > > https://git.ti.com/cgit/ti-linux-kernel/ti-linux-kernel/log/?h=ca55d70b41e > > [1] > > Link: > > https://lore.kernel.org/all/[email protected]/ > > [2] > > Signed-off-by: Jai Luthra <[email protected]> > > --- > > ...-Don-t-install-libmediactl-and-libv4.patch | 44 ++++++++++ > > ...02-original-patch-mediactl-pkgconfig.patch | 21 +++++ > > ...iginal-patch-export-mediactl-headers.patch | 24 +++++ > > .../v4l-utils/0004-Do-not-use-getsubopt.patch | 60 +++++++++++++ > > .../v4l-utils/v4l-utils_1.23.0.bb | 87 +++++++++++++++++++ > > As per my opinion, not a good idea to bump up package version than default > package version shipped by kirkstone i.e. 1.22.1 > (meta-oe/recipes-multimedia/v4l2apps/v4l-utils_1.22.1.bb) > > As a general rule of thumb, there could be other layers (for e.g. added by > vendors) having bbappends assuming shipped package version same as in > kirkstone and also build time and runtime dependencies w.r.t other packages > are guaranted if all packages stay with same version as shipped by kirkstone > and with this new recipe I believe we are kind of deviating from that > protection and so my suggestion is to rebase on top of existing package > version i.e. 1.22.1 I agree that it makes sense to keep packages pinned to a version for a particular release (dunfell/kirkstone) for stability and compatibility with other dependencies. The only issue here is multi-stream support requires a large chunk of changes to v4l2 userspace APIs, affecting the most commonly used tools for setting up the camera pipeline (media-ctl) and capturing frames (v4l2-ctl). While these changes are merged in linux upstream and backported to TI's 6.1 branch, the corresponding v4l-utils changes are still under review upstream. There are two options I see here: 1. We bump up the v4l-utils recipe in our distribution to a relatively recent git commit (v1.23.0-9431e4b26b) which is in sync with TI baseline kernel, and apply only the patches for the extra features TI uses on top. We also ensure it works well with the dependencies (mainly libc) provided by rest of the kirkstone layers (so far no issues seen in my tests) 2. We backport these patches to v1.22.1, which was tagged almost **two years ago** in Oct 2021; while the kernel is on 6.1 (Jan 2023) and using multistream APIs from 6.3/6.4/still-under-review. We will also have to sync with the latest kernel headers and extensively test that we don't break some ioctl or are missing bugfixes to v4l-utils from the past two years, as the kernel developer(s) for the newer features would not have tested against the old release. That's why I chose option 1 in the current series as an exception to the thumb rule. Let me know if it is a complete no-go to override a recipe here. > > Regards > Devarsh Thanks, Jai -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#14449): https://lists.yoctoproject.org/g/meta-arago/message/14449 Mute This Topic: https://lists.yoctoproject.org/mt/99083824/21656 Group Owner: [email protected] Unsubscribe: https://lists.yoctoproject.org/g/meta-arago/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
signature.asc
Description: PGP signature
