On 7/20/22 3:36 PM, Nishanth Menon via lists.yoctoproject.org wrote:
https://github.com/TI-ECS/eventdump unfortunately is a unmaintained
project.
LDFLAGS += -L$(NFSROOT)/lib should have dependent on NFSROOT variable.
Instead this forces the eventdump to break the sandbox and attempt to
link up against the local PC's lib - which is a NO-NO for many reasons.
Reported to have failed on a Fedora system.
Bump the PR up to indicate a fix up where we have proper linkage
Reported-by: Daniel Thompson <[email protected]>
Signed-off-by: Nishanth Menon <[email protected]>
---
PS:
1. We should probably drop the entire recipe in Master branch if this
is not maintained.. but we can fix it while we can.
Why fix it, just delete it. This tool was superseded by a better program
evtest[0]
which was already available in in OE before this was even written, why do we
keep
random throwaway projects like this around bloating our layers at all??
Andrew
[0] meta-openembedded/meta-oe/recipes-test/evtest
2. Still looking to find the owner of this repo, apparently been almost
a decade old - so probability of pending status changing for the
patch is unlikely.
.../eventdump/eventdump_git.bb | 7 ++--
...Play_nicer_with_bitbake-OpenEmbedded.patch | 34 +++++++++++++++++++
2 files changed, 39 insertions(+), 2 deletions(-)
create mode 100644
meta-arago-extras/recipes-devtools/eventdump/files/0001-PATCH_Makefile_Play_nicer_with_bitbake-OpenEmbedded.patch
diff --git a/meta-arago-extras/recipes-devtools/eventdump/eventdump_git.bb
b/meta-arago-extras/recipes-devtools/eventdump/eventdump_git.bb
index 3cd0b8e3919b..831d2e047319 100644
--- a/meta-arago-extras/recipes-devtools/eventdump/eventdump_git.bb
+++ b/meta-arago-extras/recipes-devtools/eventdump/eventdump_git.bb
@@ -2,12 +2,15 @@ SUMMARY = "Utility for parsing system events"
LICENSE = "BSD"
LIC_FILES_CHKSUM =
"file://eventdump.c;beginline=1;endline=34;md5=23b59be24a88ddc407b553035f3fd3e9"
-PR = "r3"
+PR = "r4"
PV = "1.0+git${SRCPV}"
SRCREV = "5db45a36a05a78ea44a4cb25312ed5ee3c2bd76d"
-SRC_URI = "git://github.com/TI-ECS/eventdump.git;protocol=https;branch=master"
+FILESEXTRAPATHS_prepend := "${THISDIR}/files:"
+
+SRC_URI = "git://github.com/TI-ECS/eventdump.git;protocol=https;branch=master \
+ file://0001-PATCH_Makefile_Play_nicer_with_bitbake-OpenEmbedded.patch"
S = "${WORKDIR}/git"
diff --git a/meta-arago-extras/recipes-devtools/eventdump/files/0001-PATCH_Makefile_Play_nicer_with_bitbake-OpenEmbedded.patch b/meta-arago-extras/recipes-devtools/eventdump/files/0001-PATCH_Makefile_Play_nicer_with_bitbake-OpenEmbedded.patch
new file mode 100644
index 000000000000..b14d5bb34aa2
--- /dev/null
+++
b/meta-arago-extras/recipes-devtools/eventdump/files/0001-PATCH_Makefile_Play_nicer_with_bitbake-OpenEmbedded.patch
@@ -0,0 +1,34 @@
+From e8c5094e2d59fe48ad0e7234f196d04508f53727 Mon Sep 17 00:00:00 2001
+From: Daniel Thompson <[email protected]>
+Date: Wed, 20 Jul 2022 18:05:09 +0100
+Subject: [PATCH] Makefile: Play nicer with bitbake/OpenEmbedded
+
+Unconditionally adding -L$(NFSROOT)/lib to the link line risks seriously
+confusing the linker if NFSROOT is not set (which would be common when
+building OE/bitbake) because we end up trying to link against whatever
+zany things we might find in the host /lib directory). Fix this the
+obvious way.
+
+Upstream-Status: Pending
+Signed-off-by: Daniel Thompson <[email protected]>
+---
+ Makefile | 2 ++
+ 1 file changed, 2 insertions(+)
+
+diff --git a/Makefile b/Makefile
+index e313e50..afb5472 100755
+--- a/Makefile
++++ b/Makefile
+@@ -1,7 +1,9 @@
+ CC = $(CROSS_COMPILE)gcc
+ CFLAGS = -O2 -Wall
+
++ifneq ($(NFSROOT),)
+ LDFLAGS += -L$(NFSROOT)/lib
++endif
+ #LIBS += -lopenobex -lbluetooth -lmisc
+
+ OBJS = eventdump.o
+--
+2.36.1
+
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#13959):
https://lists.yoctoproject.org/g/meta-arago/message/13959
Mute This Topic: https://lists.yoctoproject.org/mt/92513734/21656
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/meta-arago/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
