On 09:35-20220426, Andrew Davis wrote: > On 4/26/22 9:26 AM, Nishanth Menon via lists.yoctoproject.org wrote: > > Lets be clear that we work with bash and not variants such as dash. > > > > Signed-off-by: Nishanth Menon <[email protected]> > > --- > > > > There has been a bit of bashism that has crept into various checks, > > which is fine as long as folks use bash ;) OR we can start cleaning up > > in a manner to support dash and variants of that form. > > > > > I'd rather just fix the bashisms, this fixes us at least enough > to get dash back working:
> > > From 4e46cf04046aee084b4e83cef28d4500d1d3dc56 Mon Sep 17 00:00:00 2001 > From: Andrew Davis <[email protected]> > Date: Mon, 25 Apr 2022 16:31:35 -0500 > Subject: [PATCH] Fix non-standard shell usage > > Signed-off-by: Andrew Davis <[email protected]> > --- > oe-layertool-setup.sh | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/oe-layertool-setup.sh b/oe-layertool-setup.sh > index f171f94..e05737b 100755 > --- a/oe-layertool-setup.sh > +++ b/oe-layertool-setup.sh > @@ -780,7 +780,7 @@ print_image_names() { > for FOLDER in ${FOLDERS} > do > RECO="" > - if [ "${FOLDER}" == "meta-arago" ]; then > + if [ "${FOLDER}" = "meta-arago" ]; then > RECO="[recommended]" > fi > echo "From ${FOLDER}${RECO}:" > @@ -796,7 +796,7 @@ print_image_names() { > if [ -z "${summary}" ]; then > summary="No Summary available" > fi > - echo -e "\t${name}: ${summary}" > + echo " ${name}: ${summary}" Yep, fair enough - I am still not a dash fan. could you post this as an formal patch? > done > fi > done > -- > 2.17.1 > > > > oe-layertool-setup.sh | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/oe-layertool-setup.sh b/oe-layertool-setup.sh > > index f171f94cf0fc..6654869ac061 100755 > > --- a/oe-layertool-setup.sh > > +++ b/oe-layertool-setup.sh > > @@ -1,4 +1,4 @@ > > -#!/bin/sh > > +#!/bin/bash > > # OE Build Enviroment Setup Script > > # -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#13792): https://lists.yoctoproject.org/g/meta-arago/message/13792 Mute This Topic: https://lists.yoctoproject.org/mt/90708978/21656 Group Owner: [email protected] Unsubscribe: https://lists.yoctoproject.org/g/meta-arago/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
