On Mon, Oct 11, 2021 at 01:54:35PM +0530, Sinthu Raja M wrote:
> On Thu, Oct 7, 2021 at 11:37 PM Denys Dmytriyenko <[email protected]> wrote:
> >
> > On Thu, Oct 07, 2021 at 07:39:39PM +0530, Sinthu Raja wrote:
> > > From: Sinthu Raja <[email protected]>
> > >
> > > The Intel 9260 WiFi and BT firmware is already part of the linux-firmware
> > > repository.
> > >
> > > Signed-off-by: Sinthu Raja <[email protected]>
> > > ---
> > > .../linux-firmware/linux-firmware_%.bbappend | 14 +++++++++++++-
> > > 1 file changed, 13 insertions(+), 1 deletion(-)
> > >
> > > diff --git
> > > a/meta-arago-distro/recipes-kernel/linux-firmware/linux-firmware_%.bbappend
> > >
> > > b/meta-arago-distro/recipes-kernel/linux-firmware/linux-firmware_%.bbappend
> > > index 146596ad..2e2ab1c4 100644
> > > ---
> > > a/meta-arago-distro/recipes-kernel/linux-firmware/linux-firmware_%.bbappend
> > > +++
> > > b/meta-arago-distro/recipes-kernel/linux-firmware/linux-firmware_%.bbappend
> > > @@ -1,4 +1,16 @@
> > > -PR_append = ".arago0"
> > > +PR_append = ".arago1"
> > > +
> > > +PACKAGES_prepend_j7-evm =+ "${PN}-iwlwifi-9260"
> > > +PACKAGES_prepend_j7-evm =+ "${PN}-ibt-18"
> >
> > Two issues here:
> >
> > 1. use either _prepend or =+ but not both
> Hi Denys,
> I found an issue that _prepend is not working and throwing error
> during parsing the recipes, below is the error
> Nothing RPROVIDES 'linux-firmware-iwlwifi-9260'
The reason is that += and =+ automatically insert whitespace, while _prepend
and _append do not, simply concatenating strings as is, so you need to take
care of whitespaces yourself.
> But when adding only '=+', it is able to parse the recipe. So, I will
> resend the patch with the updated code.
>
> Regards,
> Sinthu Raja.
>
> > 2. making machine-specific changes to only PACKAGES isn't right for several
> > reasons - should probably be a generic change
> >
> >
> > > +LICENSE_${PN}-iwlwifi-9260 =+ "Firmware-iwlwifi_firmware"
> > > +LICENSE_${PN}-ibt-18 =+ "Firmware-ibt_firmware"
> > > +
> > > +FILES_${PN}-iwlwifi-9260 =+
> > > "${nonarch_base_libdir}/firmware/iwlwifi-9260-*.ucode"
> > > +FILES_${PN}-ibt-18 =+
> > > "${nonarch_base_libdir}/firmware/intel/ibt-18-*.sfi
> > > ${nonarch_base_libdir}/firmware/intel/ibt-18-*.ddc"
> > > +
> > > +RDEPENDS_${PN}-iwlwifi-9260 =+ "${PN}-iwlwifi-license"
> > > +RDEPENDS_${PN}-ibt-18 =+ "${PN}-ibt-license"
> > >
> > > do_install_append() {
> > > rm -rf ${D}/lib/firmware/ti-connectivity/
> > > --
> > > 2.31.1
--
Regards,
Denys Dmytriyenko <[email protected]>
PGP: 0x420902729A92C964 - https://denix.org/0x420902729A92C964
Fingerprint: 25FC E4A5 8A72 2F69 1186 6D76 4209 0272 9A92 C964
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#13345):
https://lists.yoctoproject.org/g/meta-arago/message/13345
Mute This Topic: https://lists.yoctoproject.org/mt/86353627/21656
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/meta-arago/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
