On Thu, Nov 19, 2015 at 11:31:55AM +0900, Michel Dänzer wrote: > From: Michel Dänzer <michel.daen...@amd.com> > > llvm.exp2.f32 doesn't work in some cases yet. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92709 > Signed-off-by: Michel Dänzer <michel.daen...@amd.com> > --- > > Once the problem is fixed in the LLVM AMDGPU backend, we can re-enable > llvm.exp2.f32 for the fixed LLVM version. > > src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c > b/src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c > index ac99e73..c94f109 100644 > --- a/src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c > +++ b/src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c > @@ -1539,7 +1539,7 @@ void radeon_llvm_context_init(struct > radeon_llvm_context * ctx) > bld_base->op_actions[TGSI_OPCODE_ENDIF].emit = endif_emit; > bld_base->op_actions[TGSI_OPCODE_ENDLOOP].emit = endloop_emit; > bld_base->op_actions[TGSI_OPCODE_EX2].emit = build_tgsi_intrinsic_nomem; > - bld_base->op_actions[TGSI_OPCODE_EX2].intr_name = "llvm.exp2.f32"; > + bld_base->op_actions[TGSI_OPCODE_EX2].intr_name = "llvm.AMDIL.exp.";
Do we want a native instruction here, or do we want IEEE precise exp2? If it's the former then we shouldn't be using llvm.exp2.f32 anyway. I know that we need to use llvm.AMDIL.exp. for older LLVM, but for newer LLVM, I would really like to start doing intrinsics the correct way. In this case, it means adding an llvm.amdgcn.exp.f32 intrinsic to include/llvm/IR/IntrinsicsAMDGPU.td. In the section with the amdgcn TargetPrefix. -Tom > bld_base->op_actions[TGSI_OPCODE_FLR].emit = build_tgsi_intrinsic_nomem; > bld_base->op_actions[TGSI_OPCODE_FLR].intr_name = "llvm.floor.f32"; > bld_base->op_actions[TGSI_OPCODE_FMA].emit = build_tgsi_intrinsic_nomem; > -- > 2.6.2 > > _______________________________________________ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/mesa-dev _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
