On Wed, Nov 18, 2015 at 4:17 PM, Emil Velikov <emil.l.veli...@gmail.com> wrote:
> On 18 November 2015 at 22:39, Nanley Chery <nanleych...@gmail.com> wrote: > > On Wed, Nov 18, 2015 at 12:33 PM, Emil Velikov <emil.l.veli...@gmail.com > > > > wrote: > >> > >> Hi Nanley, > >> > >> On 18 November 2015 at 20:29, Nanley Chery <nanleych...@gmail.com> > wrote: > >> > From: Nanley Chery <nanley.g.ch...@intel.com> > >> > > >> > Help developers understand the table's organization. > >> > > >> > Suggested-by: Jason Ekstrand <ja...@jlekstrand.net> > >> > Signed-off-by: Nanley Chery <nanley.g.ch...@intel.com> > >> Can you bring back the comments that were in here, please. They might > >> have cause issues with sed prior but things should be fine now. Also > >> move the existing FIXME as originally, as mentioned by Marek and > >> myself. > >> > > > > There's one more organizational change that's possible - sorting the > table > > alphabetically. The original comments would probably be unnecessary if we > > choose to perform that change. > > > > When first adding ASTC to the table, I did not place the extensions in > the > > right rows partly because the existing alphabetical sorting was > > inconsistent. By completely sorting the table it becomes a easier to > > determine where to place new extensions. > > > > If the sorted order is checked with a gtest, it would then be possible to > > know if the table is sorted and, if desired, perform a bsearch on the > table. > > I'll send out a patch to test interest on this. I have a wip branch that > > does what I've described (minus the bsearch) : > > http://cgit.freedesktop.org/~nchery/mesa/log/?h=ext_sort > > > Sure, with sorting in place we can ignore the previous (original) > comments. The bsearch will bring some benefit only as one overrides > extensions or there is some other place that I'm missing ? > > That's the only place where it is applicable unfortunately. For that reason, I did not implement the code for that functionality. Most of the benefit IMO comes from helping developers insert new extensions in the correct positions. > > Wrt to the FIXME, I was confused by your original comment and thought > that > > you actually wanted the FIXME on the same line as the extension. Hence, > my > > comment about there being no unanimous opinion on the change. I wasn't > sure > > what action to take in the midst of the perceived disagreement, but now > that > > I understand your comment, I'll send out the patch for it. > > > Hmm ? /me rereads his message > > Sorry for not providing the context: http://lists.freedesktop.org/archives/mesa-dev/2015-October/098182.html > Please don't be shy/afraid/too polite to call me and others out. If we > have X "for" and Y "against" just draw the line and (explicitly) say > which one you're going with. Otherwise one can never know if they came > across (were understood) correctly. > > I originally did say that I would leave the FIXME, but I'll try to improve in this aspect of my communication. Regards, Nanley Thanks > Emil >
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
