On 07.11.2015 12:05, Vivek Kasireddy wrote: > For certain platforms that support rotated scanout buffers, currently, > there is no way to create them with the GBM DRI interface. These flags > will instruct the DRI driver to create the buffer by setting > additional requirements such as tiling mode. > > v2: Reserve a bit per angle. (Ville and Michel) > > v3: > - Combine all GBM_BO_USE_SCANOUT_ROTATION_* flags into > GBM_BO_USE_SCANOUT_ANY macro (Michel) > - Pull the code that updates dri_use based on the rotation flag > into a separate function. > > v4: > - Added a brief comment to explain the rotation orientation. > - Augmented the helper function gbm_to_dri_flag() introduced in v3 > to handle GBM_BO_USE_CURSOR and GBM_BO_USE_LINEAR as well. (Michel)
It would be cleaner to split out the refactoring of the handling of existing flags into gbm_to_dri_flag() in a new patch 2, and only add the new flags in a new patch 3. Apart from that and the typo pointed out by Dieter, looks good to me. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
