On Thu, Nov 12, 2015 at 9:36 PM, Jason Ekstrand <ja...@jlekstrand.net> wrote: > bump! Where are we at on this?
Go ahead and push it with my r-b. I still think glsl_type::is_vector_or_scalar() should return true for subroutine types, but that might require some more fixing and testing. > > On Tue, Nov 10, 2015 at 6:16 PM, Dave Airlie <airl...@gmail.com> wrote: >>>> >>>> Well, it's not just a NIR thing -- GLSL IR also effectively treats >>>> subroutines as integers. Actually, I wonder why the >>>> glsl_type::is_vector_or_scalar() doesn't return true for subroutine >>>> types in the first place. >>> >>> For that matter, why do we have a special subroutine type at all? Why >>> doesn't the GLSL lowering pass create regular uint uniforms? I don't >>> know. >> >> I'm not sure what reasoning I had at the time. >> >> It is probably something to do with how Mesa and GLSL IR are tied togetther >> for >> uniforms and requiring an extra type for it to make sense at the API level. >> >> Dave. _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
