On Monday, November 02, 2015 04:29:16 PM Matt Turner wrote:
[snip]
> diff --git a/src/mesa/drivers/dri/i965/brw_fs_generator.cpp
> b/src/mesa/drivers/dri/i965/brw_fs_generator.cpp
> index e980003..ed3e335 100644
> --- a/src/mesa/drivers/dri/i965/brw_fs_generator.cpp
> +++ b/src/mesa/drivers/dri/i965/brw_fs_generator.cpp
> @@ -33,7 +33,8 @@
> #include "brw_fs.h"
> #include "brw_cfg.h"
>
> -static uint32_t brw_file_from_reg(fs_reg *reg)
> +static enum brw_reg_file
> +brw_file_from_reg(fs_reg *reg)
> {
> switch (reg->file) {
> case GRF:
> @@ -48,7 +49,7 @@ static uint32_t brw_file_from_reg(fs_reg *reg)
> case UNIFORM:
> unreachable("not reached");
> }
> - return 0;
> + return GRF;
> }I agree with Emil, let's make this BRW_ARCHITECTURE_REGISTER_FILE. Mostly, I don't like it returning "GRF" because this returns BRW_*_FILE enums, which are separate from the GRF/MRF/etc. enum. --Ken
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
