https://bugs.freedesktop.org/show_bug.cgi?id=92552
--- Comment #10 from Matthew Waters <ystree...@gmail.com> --- (In reply to Ian Romanick from comment #9) > Comment on attachment 119006 [details] [review] > egl: distnguish between unsupported api vs capabilities for EGL_CONTEXT_FLAGS > > Review of attachment 119006 [details] [review]: > ----------------------------------------------------------------- > > There are a few things wrong with this patch. First, you can't check the > version when you see EGL_CONTEXT_FLAGS in the attribs list because the > application could specify the requested version after flags. This should > not generate an error: > > EGL_CONTEXT_FLAGS, EGL_CONTEXT_OPENGL_FORWARD_COMPATIBLE_BIT_KHR, > EGL_CONTEXT_CLIENT_VERSION, 3, > 0 Right, will fix. > Second, it is not correct to generate EGL_BAD_MATCH for > EGL_CONTEXT_OPENGL_ROBUST_ACCESS_BIT_KHR when > EGL_EXT_create_context_robustness is not supported. Think of it this way... > if we deleted all support and knowledge of > EGL_EXT_create_context_robustness, what error would be generated? Default > case in the switch statement says EGL_BAD_ATTRIBUTE. Not sure what you're trying to say here. Couple of interpretations: 1. Unknown bit in EGL_CONTEXT_FLAGS -> specs are pretty clear that EGL_BAD_ATTRIBUTE should be returned 2. EGL_CONTEXT_OPENGL_ROBUST_ACCESS_BIT_KHR is only defined for OpenGL contexts (not ES) -> taken care of previously and will return EGL_BAD_ATTRIBUTE. 3. Removing support for EGL_EXT_create_context_robustness is not the same as removing support for GL_ARB_robustness. My question then is, do we have a way we can check for GL_ARB_robustness from the egl code or is it always (not?) supported? -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
