On 10/22/2015 01:02 AM, Julien Isorce wrote:
Sorry this patch should not have gone in the v2 since it has been
already reviewed by Emil. But thx for your review.
I experienced the crash when testing patch 5/7 of this patch series,
around "resource = pscreen->resource_from_handle" in the new
vaCreateSurface2 function. Just passing a wrong fd.
I checked your remark for nv50 and nv30 and they don't make this step.
From what I can see, nvc0 re-use nv50_miptree_from_handle from nv50
but still has its own nvc0_miptree_vtbl. But that's just a guess :)
ACK.
Thanks for your answer.
Do you need someone to push this patch?
Cheers
Julien
On 20 October 2015 at 18:04, samuel.pitoiset
<samuel.pitoi...@gmail.com <mailto:samuel.pitoi...@gmail.com>> wrote:
Is there a particular situation where nv50_miptree_from_handle()
fails? And did you check nv50?
Anyway, this patch is:
Reviewed-by: Samuel Pitoiset <samuel.pitoi...@gmail.com
<mailto:samuel.pitoi...@gmail.com>>
On 20/10/2015 18:34, Julien Isorce wrote:
Signed-off-by: Julien Isorce <j.iso...@samsung.com
<mailto:j.iso...@samsung.com>>
---
src/gallium/drivers/nouveau/nvc0/nvc0_resource.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_resource.c
b/src/gallium/drivers/nouveau/nvc0/nvc0_resource.c
index 12b5a02..15c803c 100644
--- a/src/gallium/drivers/nouveau/nvc0/nvc0_resource.c
+++ b/src/gallium/drivers/nouveau/nvc0/nvc0_resource.c
@@ -26,7 +26,8 @@ nvc0_resource_from_handle(struct pipe_screen
* screen,
} else {
struct pipe_resource *res =
nv50_miptree_from_handle(screen,
templ, whandle);
- nv04_resource(res)->vtbl = &nvc0_miptree_vtbl;
+ if (res)
+ nv04_resource(res)->vtbl = &nvc0_miptree_vtbl;
return res;
}
}
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org <mailto:mesa-dev@lists.freedesktop.org>
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
