On Tuesday, October 20, 2015 02:29:38 PM Ben Widawsky wrote:
> All the documentation I can find says that this bit (and functionality) only
> exists on SKL+. Since the bit isn't yet used, there is no real impact here.
> 
> The original code was added by Ken here (a surprisingly long time ago):
> commit f3c6d6f1e151f6a44a76038dccebe4434038dcb1
> Author: Kenneth Graunke <kenn...@whitecape.org>
> Date:   Thu Nov 29 21:00:27 2012 -0800
> 
>     i965: Update 3DSTATE_PS, 3DSTATE_WM, and add 3DSTATE_PS_EXTRA.
> 
> Cc: Kenneth Graunke <kenn...@whitecape.org>
> Signed-off-by: Ben Widawsky <b...@bwidawsk.net>
> ---
>  src/mesa/drivers/dri/i965/brw_defines.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/mesa/drivers/dri/i965/brw_defines.h 
> b/src/mesa/drivers/dri/i965/brw_defines.h
> index e06c9d6..215f454 100644
> --- a/src/mesa/drivers/dri/i965/brw_defines.h
> +++ b/src/mesa/drivers/dri/i965/brw_defines.h
> @@ -2385,7 +2385,7 @@ enum brw_pixel_shader_coverage_mask_mode {
>  # define GEN8_PSX_ATTRIBUTE_ENABLE                      (1 << 8)
>  # define GEN8_PSX_SHADER_DISABLES_ALPHA_TO_COVERAGE     (1 << 7)
>  # define GEN8_PSX_SHADER_IS_PER_SAMPLE                  (1 << 6)
> -# define GEN8_PSX_SHADER_COMPUTES_STENCIL               (1 << 5)
> +# define GEN9_PSX_SHADER_COMPUTES_STENCIL               (1 << 5)
>  # define GEN9_PSX_SHADER_PULLS_BARY                     (1 << 3)
>  # define GEN8_PSX_SHADER_HAS_UAV                        (1 << 2)
>  # define GEN8_PSX_SHADER_USES_INPUT_COVERAGE_MASK       (1 << 1)

Yup, this is Skylake+.  Who knows what docs I was looking at in 2012? :)

Reviewed-by: Kenneth Graunke <kenn...@whitecape.org>

Attachment: signature.asc
Description: This is a digitally signed message part.

_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to