On Mon, Oct 19, 2015 at 3:51 PM, Ilia Mirkin <imir...@alum.mit.edu> wrote:
> On Mon, Oct 19, 2015 at 3:47 PM, Rob Clark <robdcl...@gmail.com> wrote:
>> Also, there is some trivial shader variant handling in mesa st which
>> would have to be ported to NIR. Or, perhaps, just somehow expose the
>> shader key to the driver. (Currently most drivers are doing much more
>> variant handling within the driver, and having two levels of variants
>> does seem a bit silly.)
>
> With Marek's latest series, the are no more variants in st/mesa (well,
> except for glDrawPixels/glBitmap-related shaders) provided that your
> driver exposes the right caps.
Ok, I guess I should rebase onto that.. I think the
glDrawPixels/glBitmap paths will still be TGSI.. so only having to
deal with variants in the GLSL->whatever path in drivers would be
nice..
(note: I should probably point out some TODO comments I had in the
freedreno/ir3 parts about cso->{tokens/nir/etc} lifetime.. the current
state of having to dup/clone in driver since sometimes cso->tokens
don't exist after the pipe->create_xyz_state() is a bit ugly..)
BR,
-R
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
