On 19 October 2015 at 18:17, Ilia Mirkin <imir...@alum.mit.edu> wrote: > On Mon, Oct 19, 2015 at 1:10 PM, Emil Velikov <emil.l.veli...@gmail.com> > wrote: >> On 17 October 2015 at 00:14, Julien Isorce <julien.iso...@gmail.com> wrote: >>> if (!ctx) >>> return VA_STATUS_ERROR_INVALID_CONTEXT; >>> >>> - if (!(picture_width && picture_height)) >>> + is_vpp = config_id == PIPE_VIDEO_PROFILE_UNKNOWN && >>> + picture_width == 0 && picture_height == 0 && flag ==0 && >>> !render_targets >>> + && num_render_targets == 0; >> Please indent - all the conditionals should start at the same column >> and nuke the == 0. > > I think the indentation is perfectly fine, although the && should be > at the end not at the beginning. What's wrong with the == 0? (except > that one of them has a missing space)? Such matters of taste should be > left up to the original author. > All of these (and other nitpicks in the series) are based on following the surrounding code. If people feel strongly against them, then be my guest to ignore :-)
-Emil _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
