On Sat, Oct 10, 2015 at 4:24 AM, Alejandro Piñeiro <apinhe...@igalia.com> wrote: > --- > > I found this useful while I was using INTEL_DEBUG=optimizer after > changing how the ifs are emitted. And after all, that info is > also included by brw_disasm.c
Definitely. > I assumed that at the vec4_visitor we would not need to handle > pred_ctrl_align1, but Im not totally sure. That's correct. > > src/mesa/drivers/dri/i965/brw_vec4.cpp | 16 ++++++++++++++-- > 1 file changed, 14 insertions(+), 2 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_vec4.cpp > b/src/mesa/drivers/dri/i965/brw_vec4.cpp > index 55e381b..eb81523 100644 > --- a/src/mesa/drivers/dri/i965/brw_vec4.cpp > +++ b/src/mesa/drivers/dri/i965/brw_vec4.cpp > @@ -1358,9 +1358,21 @@ vec4_visitor::dump_instruction(backend_instruction > *be_inst, FILE *file) > vec4_instruction *inst = (vec4_instruction *)be_inst; > > if (inst->predicate) { > - fprintf(file, "(%cf0.%d) ", > + static const char *const pred_ctrl_align16[16] = { > + "", > + "", > + ".x", > + ".y", > + ".z", > + ".w", > + ".any4h", > + ".all4h", > + }; Let's just externalize pred_ctrl_align16 from brw_disasm.c and use it here. See for example commit b9af66528e5b7bd. With that change, Reviewed-by: Matt Turner <matts...@gmail.com> _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev