On 09/10/2015 10:14 AM, Ilia Mirkin wrote:
On Thu, Sep 10, 2015 at 12:12 PM, Krzesimir Nowak <krzesi...@kinvolk.io> wrote:
On Thu, Sep 10, 2015 at 5:54 PM, Roland Scheidegger <srol...@vmware.com>
wrote:

Am 10.09.2015 um 14:15 schrieb Krzesimir Nowak:
I tried to address most of the issues and nitpicks you had in previous
version. Please see updated commit messages to see what has changed.

I also added another commit updating the release notes and the GL3.txt.

Krzesimir Nowak (10):
   tgsi: Remove trailing backslash in comment
   softpipe: Fix textureLod with nonzero GL_TEXTURE_LOD_BIAS value
   softpipe: Split compute_lambda_lod into two functions
   softpipe: Put mip_filter_func inside a struct
   softpipe: Split code getting a filter into separate function
   softpipe: Split 3D to 2D coords conversion into separate function
   softpipe: Add functions for computing relative mipmap level
   tgsi: Add code for handling lodq opcode
   softpipe: Implement and enable textureQueryLod
   docs: Update wrt. textureQueryLod on softpipe

  docs/GL3.txt                                 |   2 +-
  docs/relnotes/11.1.0.html                    |   1 +
  src/gallium/auxiliary/tgsi/tgsi_exec.c       |  48 +++-
  src/gallium/auxiliary/tgsi/tgsi_exec.h       |  10 +
  src/gallium/drivers/softpipe/sp_screen.c     |   2 +-
  src/gallium/drivers/softpipe/sp_tex_sample.c | 403
+++++++++++++++++++++------
  src/gallium/drivers/softpipe/sp_tex_sample.h |  23 +-
  7 files changed, 393 insertions(+), 96 deletions(-)


Looks good to me, thanks for the cleanups.
For the series:
Reviewed-by: Roland Scheidegger <srol...@vmware.com>


Thanks for the reviews. But for the record - I don't have write access to
git repo. Do you want me to reroll the series again with additional
"Reviewed-by:" line in commit messages? Not sure what is the process here.

Sit tight and wait :) Brian said he'd push. If he doesn't do that
within some period of time that you feel is too long, you could put a
branch together somewhere with all the R-b's and email with a reminder
and oh-hey-btw here's a branch you can just push out.

I pushed the series a bit ago. But before I saw Roland's R-b. I would have added Roland's R-b otherwise.

-Brian


_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to