Regardless of what happens with the rest of this series, I think this is a reasonable cleanup. This patch is
Reviewed-by: Ian Romanick <ian.d.roman...@intel.com> On 09/09/2015 06:38 AM, Chris Wilson wrote: > The very first operation performed by _mesa_readpixels() is to call > _mesa_update_state() - we do not need to do so ourselves. > > Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk> > Cc: Jordan Justen <jordan.l.jus...@intel.com> > Cc: Jason Ekstrand <jason.ekstr...@intel.com> > Cc: Kenneth Graunke <kenn...@whitecape.org> > Cc: Francisco Jerez <curroje...@riseup.net> > --- > src/mesa/drivers/dri/i965/intel_pixel_read.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/intel_pixel_read.c > b/src/mesa/drivers/dri/i965/intel_pixel_read.c > index eb366cd..16dcc55 100644 > --- a/src/mesa/drivers/dri/i965/intel_pixel_read.c > +++ b/src/mesa/drivers/dri/i965/intel_pixel_read.c > @@ -269,14 +269,6 @@ intelReadPixels(struct gl_context * ctx, > intel_prepare_render(brw); > brw->front_buffer_dirty = dirty; > > - /* Update Mesa state before calling _mesa_readpixels(). > - * XXX this may not be needed since ReadPixels no longer uses the > - * span code. > - */ > - > - if (ctx->NewState) > - _mesa_update_state(ctx); > - > _mesa_readpixels(ctx, x, y, width, height, format, type, pack, pixels); > > /* There's an intel_prepare_render() call in intelSpanRenderStart(). */ > _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
