On Saturday, September 05, 2015 08:58:07 PM Chris Wilson wrote: > On Sat, Sep 05, 2015 at 11:30:44AM -0700, Jordan Justen wrote: > > From: Francisco Jerez <curroje...@riseup.net> > > > > Fixes > > arb_shader_image_load_store/execution/load-from-cleared-image.shader_test > > > > Cc: Chris Wilson <ch...@chris-wilson.co.uk> > > Cc: Jason Ekstrand <jason.ekstr...@intel.com> > > Tested-by: Jordan Justen <jordan.l.jus...@intel.com> > > --- > > RE: i965: Perform an explicit flush after doing _mesa_meta_pbo_TexSubImage > > > > curro has some concerns about potential perf impact by this and > > wanted it to be checked on small-core w/CPU bound apps. > > Unfortunately, he is on vacation now. > > One thing that may help (other than having a bitfield of valid > ImageUnits being more cache friendly) is that intel_update_state() need > only invalidate state. Moving the heavyweight resolves/flushes to just > prior to running the pipeline should help reduce the profile of the > fairly frequently called mesa_update_state(). > -Chris
_________________________________ < welcome to recursive meta hell! > --------------------------------- \ / \ //\ \ |\___/| / \// \\ /0 0 \__ / // | \ \ / / \/_/ // | \ \ @_^_@'/ \/_ // | \ \ //_^_/ \/_ // | \ \ ( //) | \/// | \ \ ( / /) _|_ / ) // | \ _\ ( // /) '/,_ _ _/ ( ; -. | _ _\.-~ .-~~~^-. (( / / )) ,-{ _ `-.|.-~-. .~ `. (( // / )) '/\ / ~-. _ .-~ .-~^-. \ (( /// )) `. { } / \ \ (( / )) .----~-.\ \-' .~ \ `. \^-. ///.----..> \ _ -~ `. ^-` ^-_ ///-._ _ _ _ _ _ _}^ - - - - ~ ~-- ,.-~ /.-~ That sounds reasonable, but fair warning: Kristian spent literally a month trying to figure out how to make this work, and we tried a wide variety of reasonable sounding plans that ended up falling apart. Awkward resolve timings make for a world of nasty corner cases. --Ken
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev