On Saturday, August 29, 2015 02:23:58 AM Kenneth Graunke wrote: > This is now only used for the vertex shader, so it makes sense to get it > out of any paths run by the geometry shader. > > By wrapping the run() method, we can eliminate the bogus NULL > parameter in the GS case, and do VS things only for the VS.
This bit of the commit message is bunk, from a previous version of the patch where I actually added separate run() methods to each subclass. I've replaced the "By wrapping the run()..." text with: "Instead of passing the gl_clip_plane array into the run() method (which is shared among all subclasses), we add it as a vec4_vs_visitor constructor parameter. This eliminates the bogus NULL parameter in the GS case."
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
