On Wed, Aug 26, 2015 at 2:43 AM, Kenneth Graunke <kenn...@whitecape.org> wrote:
> driParseDebugString() doesn't have actual code to parse comma separated
> lists (or any other supported options?); instead it dumbly uses strstr().
>
> This means that INTEL_DEBUG="vec4vs" will trigger both DEBUG_VEC4VS and
> DEBUG_VS, as "vs" is also a substring.
>
> We should probably improve the driconf parsing, but for now, just rename
> the option so it's usable in the meantime.

Hehe, yes, sorry about that. Looks good to me, in fact, just 'vec4'
make more sense as it applies to other geometry stages.

Kristian

> Signed-off-by: Kenneth Graunke <kenn...@whitecape.org>
> ---
>  src/mesa/drivers/dri/i965/intel_debug.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/mesa/drivers/dri/i965/intel_debug.c 
> b/src/mesa/drivers/dri/i965/intel_debug.c
> index a077731..b3b3c21 100644
> --- a/src/mesa/drivers/dri/i965/intel_debug.c
> +++ b/src/mesa/drivers/dri/i965/intel_debug.c
> @@ -68,7 +68,7 @@ static const struct dri_debug_control debug_control[] = {
>     { "optimizer",   DEBUG_OPTIMIZER },
>     { "ann",         DEBUG_ANNOTATION },
>     { "no8",         DEBUG_NO8 },
> -   { "vec4vs",      DEBUG_VEC4VS },
> +   { "vec4",        DEBUG_VEC4VS },
>     { "spill",       DEBUG_SPILL },
>     { "cs",          DEBUG_CS },
>     { NULL,    0 }
> --
> 2.5.0
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to