On Tue 11 Aug 2015, Nanley Chery wrote: > From: Nanley Chery <nanley.g.ch...@intel.com> > > All compressed formats return GL_FALSE. Remove all switch cases for > compressed formats. Compressed formats should be at the bottom of > the switch statement, so ordering is still preserved. > > Cc: Jason Ekstrand <jason.ekstr...@intel.com> > Signed-off-by: Nanley Chery <nanley.g.ch...@intel.com> > --- > src/mesa/main/formats.c | 47 ++--------------------------------------------- > 1 file changed, 2 insertions(+), 45 deletions(-)
This patch has the same issue as patch 1/4. It transforms an intentionaly exhaustive switch to an unintentionally inexhaustive switch, spewing compiler warnings. If you want to move all the compressed cases to the bottom of the switch, I think that's a good idea. But I think this switch should remain exhaustive. _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev