Re: [Mesa-dev] [PATCH 2/2] radeonsi: ubo indexing support (v2)

[Marek Olšák]

Reviewed-by: Marek Olšák <marek.ol...@amd.com>

Marek

On Fri, Jul 24, 2015 at 6:43 AM, Dave Airlie <airl...@gmail.com> wrote:
> From: Dave Airlie <airl...@redhat.com>
>
> This is required as part of ARB_gpu_shader5.
>
> no backend changes are required for this, or if
> any are, it's the same ones as for samplers.
>
> v2: use get_indirect_index (Marek)
>
> Signed-off-by: Dave Airlie <airl...@redhat.com>
> ---
>  docs/GL3.txt                             |  2 +-
>  src/gallium/drivers/radeonsi/si_shader.c | 15 ++++++++++++---
>  2 files changed, 13 insertions(+), 4 deletions(-)
>
> diff --git a/docs/GL3.txt b/docs/GL3.txt
> index 4869b66..258a6fb 100644
> --- a/docs/GL3.txt
> +++ b/docs/GL3.txt
> @@ -99,7 +99,7 @@ GL 4.0, GLSL 4.00:
>    GL_ARB_gpu_shader5                                   DONE (i965, nvc0)
>    - 'precise' qualifier                                DONE
>    - Dynamically uniform sampler array indices          DONE (r600, radeonsi, 
> softpipe)
> -  - Dynamically uniform UBO array indices              DONE (r600)
> +  - Dynamically uniform UBO array indices              DONE (r600, radeonsi)
>    - Implicit signed -> unsigned conversions            DONE
>    - Fused multiply-add                                 DONE ()
>    - Packing/bitfield/conversion functions              DONE (r600, radeonsi, 
> softpipe)
> diff --git a/src/gallium/drivers/radeonsi/si_shader.c 
> b/src/gallium/drivers/radeonsi/si_shader.c
> index 14f997b..3c05fd4 100644
> --- a/src/gallium/drivers/radeonsi/si_shader.c
> +++ b/src/gallium/drivers/radeonsi/si_shader.c
> @@ -1191,7 +1191,7 @@ static LLVMValueRef fetch_constant(
>         const struct tgsi_ind_register *ireg = &reg->Indirect;
>         unsigned buf, idx;
>
> -       LLVMValueRef addr;
> +       LLVMValueRef addr, bufp;
>         LLVMValueRef result;
>
>         if (swizzle == LP_CHAN_ALL) {
> @@ -1206,7 +1206,7 @@ static LLVMValueRef fetch_constant(
>         buf = reg->Register.Dimension ? reg->Dimension.Index : 0;
>         idx = reg->Register.Index * 4 + swizzle;
>
> -       if (!reg->Register.Indirect) {
> +       if (!reg->Register.Indirect && !reg->Dimension.Indirect) {
>                 if (type != TGSI_TYPE_DOUBLE)
>                         return bitcast(bld_base, type, 
> si_shader_ctx->constants[buf][idx]);
>                 else {
> @@ -1216,13 +1216,22 @@ static LLVMValueRef fetch_constant(
>                 }
>         }
>
> +       if (reg->Register.Dimension && reg->Dimension.Indirect) {
> +               LLVMValueRef ptr = 
> LLVMGetParam(si_shader_ctx->radeon_bld.main_fn, SI_PARAM_CONST);
> +               LLVMValueRef index;
> +               index = get_indirect_index(si_shader_ctx, &reg->DimIndirect,
> +                                                  reg->Dimension.Index);
> +               bufp = build_indexed_load_const(si_shader_ctx, ptr, index);
> +       } else
> +               bufp = si_shader_ctx->const_resource[buf];
> +
>         addr = si_shader_ctx->radeon_bld.soa.addr[ireg->Index][ireg->Swizzle];
>         addr = LLVMBuildLoad(base->gallivm->builder, addr, "load addr reg");
>         addr = lp_build_mul_imm(&bld_base->uint_bld, addr, 16);
>         addr = lp_build_add(&bld_base->uint_bld, addr,
>                             lp_build_const_int32(base->gallivm, idx * 4));
>
> -       result = buffer_load_const(base->gallivm->builder, 
> si_shader_ctx->const_resource[buf],
> +       result = buffer_load_const(base->gallivm->builder, bufp,
>                                    addr, bld_base->base.elem_type);
>
>         if (type != TGSI_TYPE_DOUBLE)
> --
> 2.4.3
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev