On 24.07.2015 08:11, Marek Olšák wrote: > From: Marek Olšák <marek.ol...@amd.com> > > +4 piglits
Awesome! I love piglits. :) Just some cosmetic issues: > @@ -174,7 +174,8 @@ static inline LLVMValueRef bitcast( > > void radeon_llvm_emit_prepare_cube_coords(struct lp_build_tgsi_context * > bld_base, > struct lp_build_emit_data * > emit_data, > - LLVMValueRef *coords_arg); > + LLVMValueRef *coords_arg, > + LLVMValueRef *derivs_arg); Indentation is inconsistent between these two lines. > + derivs[axis*2+i] = > + LLVMBuildFSub(builder, > shifted_coords[i], > + coords[i], ""); I think the arithmetic is more readable with spaces: derivs[axis * 2 + i] = But I'm fine with this either way. With the inconsistent indentation fixed, Reviewed-by: Michel Dänzer <michel.daen...@amd.com> -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev