Am 13.07.2015 um 17:58 schrieb Emil Velikov:
> On 11 July 2015 at 19:39, <srol...@vmware.com> wrote:
>
>> @@ -186,17 +172,24 @@ static inline void emit_cb_setup(struct r100_context
>> *r100,
>>
>> /* XXX others? BE/LE? */
> Drop the BE/LE part of the comment ?
>
>> switch (mesa_format) {
>> + /* le */
>> case MESA_FORMAT_B8G8R8A8_UNORM:
>> case MESA_FORMAT_B8G8R8X8_UNORM:
>> + /* be */
>> + case MESA_FORMAT_A8R8G8B8_UNORM:
>> + case MESA_FORMAT_X8R8G8B8_UNORM:
> Something like the following might be easier for you/others X months
> down the line.
>
> + /* The former format of each pair is for LE while latter for BE systems.
> */
> switch (mesa_format) {
> case MESA_FORMAT_B8G8R8A8_UNORM:
> + case MESA_FORMAT_A8R8G8B8_UNORM:
> case MESA_FORMAT_B8G8R8X8_UNORM:
> + case MESA_FORMAT_X8R8G8B8_UNORM:
>
> Same suggestion applies for 4/4.
>
> -Emil
>
Thanks for the feedback. All fixed (and added some more comments even).
Roland
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
