https://bugs.freedesktop.org/show_bug.cgi?id=91290
Vinson Lee <v...@freedesktop.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression CC| |anuj.pho...@gmail.com, | |cwo...@cworth.org Version|git |10.3 --- Comment #1 from Vinson Lee <v...@freedesktop.org> --- a6e9cd14cad555520ad98213adf541a7687a7498 is the first bad commit commit a6e9cd14cad555520ad98213adf541a7687a7498 Author: Anuj Phogat <anuj.pho...@gmail.com> Date: Fri Jun 6 16:56:59 2014 -0700 glsl/glcpp: Fix preprocessor error condition for macro redefinition This patch specifically fixes redefinition condition for white space changes. #define and #undef functionality in GLSL follows the standard for C++ preprocessors for macro definitions. From https://gcc.gnu.org/onlinedocs/cpp/Undefining-and-Redefining-Macros.html: These definitions are effectively the same: #define FOUR (2 + 2) #define FOUR (2 + 2) #define FOUR (2 /* two */ + 2) but these are not: #define FOUR (2 + 2) #define FOUR ( 2+2 ) #define FOUR (2 * 2) #define FOUR(score,and,seven,years,ago) (2 + 2) Fixes Khronos GLES3 CTS tests; invalid_object_whitespace_vertex invalid_object_whitespace_fragment Signed-off-by: Anuj Phogat <anuj.pho...@gmail.com> Reviewed-by: Carl Worth <cwo...@cworth.org> :040000 040000 21e3582eed6555a0e4510982863892e0ead45930 6bb0f8508d19b41b5938b9f812b793ba90c278a0 M src bisect run success -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev