On Tue, Jun 23, 2015 at 12:05 PM, Chad Versace <chad.vers...@intel.com> wrote: > On Fri 19 Jun 2015, Emil Velikov wrote: >> Cc: "10.5 10.6" <mesa-sta...@lists.freedesktop.org> >> Suggested-by: Ilia Mirkin <imir...@alum.mit.edu> >> Signed-off-by: Emil Velikov <emil.l.veli...@gmail.com> > > >> -urls=$(git log $* | grep 'bugs.freedesktop.org/show_bug' | sed -e >> $trim_before -e $trim_after -e $use_https | sort | uniq) >> +urls=$(git log $* | grep 'bugs.freedesktop.org/show_bug' | sed -e >> $trim_before -e $trim_after -e $use_https | sort-n | uniq) > > That can't be right! A space is needed between 'sort' and '-n'.
The approach is flawed... sort -n expects the number first, not in the middle/last. This was my suggestion to Emil: git log $* | grep 'bugs.freedesktop.org/show_bug' | sed -e 's/.*show_bug.cgi?id=\([0-9]*\).*/\1/' | sort -n -u | sed 's,^,https://bugs.freedesktop.org/show_bug.cgi?id=,' > > Add the space, and this is > Reviewed-by: Chad Versace <chad.vers...@intel.com> > > _______________________________________________ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/mesa-dev _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
