2015-05-20 16:35 GMT+08:00 Petri Latvala <petri.latv...@intel.com>: > On 05/20/2015 06:30 AM, Ilia Mirkin wrote: >> >> + typedef const iterator const_iterator; >> + > > This at least is wrong. A const iterator allows *iter = val, a > const_iterator doesn't. A const_iterator allows ++, a const iterator > doesn't.
You're right. Thank you! The const_iterator should be derived from _base::const_iterator. After review the code again, the unordered_set::const_iterator is not used except in Value::UseCIterator, but the latter is not used, either. So I think it's safe to remove it at all. -- Chih-Wei Android-x86 project http://www.android-x86.org _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
