On 08/05/2015 18:07, Emil Velikov a wrote :

Let's use drmGetNodeTypeFromFd(), rather than hard-coding this ?


+
+   for (i = 0; extensions[i]; i++) {
+      if (strcmp(extensions[i]->name, __DRI_IMAGE_DRIVER) == 0)
+         return EGL_TRUE;
If memory serves me right__DRI_IMAGE_DRIVER is a cleaned up version of
__DRI_DRI2. Afaics the former is never looked up (or used) in the EGL
code, unlike the latter. So I'm suspecting that this check is a bit
off ?

Thanks
Emil

Thanks for catching for wrong check, I send right away a patch with that fixed

for drmGetNodeTypeFromFd, it looks like a very recent libdrm function, and we would require libdrm 2.4.60, which is quite recent. Currently mesa requires 2.4.38, when libdrm is needed. I guess we cannot require 2.4.60 for now.

Yours,

Axel Davy
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to